netdev - Re: [PATCH V5 04/22] qlcnic: modify PCI and register access routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121102.212732.478167267058337431.davem@davemloft.net>
Date:	Fri, 02 Nov 2012 21:27:32 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sony.chacko@...gic.com
Cc:	netdev@...r.kernel.org, Dept_NX_Linux_NIC_Driver@...gic.com
Subject: Re: [PATCH V5 04/22] qlcnic: modify PCI and register access
 routines

From: Sony Chacko <sony.chacko@...gic.com>
Date: Thu,  1 Nov 2012 21:06:36 -0400

> From: Sony Chacko <sony.chacko@...gic.com>
> 
> Refactor 82xx driver to support new adapter - Qlogic 83XX CNA
> Update PCI and hardware access routines
> 
> Signed-off-by: Anirban Chakraborty <anirban.chakraborty@...gic.com>
> Signed-off-by: Sony Chacko <sony.chacko@...gic.com>

This removes the only user of qlcnic_check_vf() but leaves the
definition around, dangling, and creating a build warning:

drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:454:1: warning: ‘qlcnic_check_vf’ defined but not used [-Wunused-function]

Before you even bother sending this series yet another time, I want
you to do what I'm going to do with your patches anyways, which is
apply them one by one and verify that at each and every patch there
are no build failures or new warnings introduced.

My patience with you guys is wearing thin, and after being without
power or heat for 5 days I'm really grumpy.  So you better take
your time and make sure this thing is perfect before you even
think about posting it again.

Thanks.