netdev - Re: [PATCH net-next] macb: Keep driver's speed/duplex in sync with actual NCFGR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121103.153813.1907662993079093598.davem@davemloft.net>
Date:	Sat, 03 Nov 2012 15:38:13 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vitas@...factor.kiev.ua
Cc:	netdev@...r.kernel.org, nicolas.ferre@...el.com,
	plagnioj@...osoft.com, havard@...nnemoen.net, jamie@...ieiles.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net-next] macb: Keep driver's speed/duplex in sync with
 actual NCFGR

From: Vitalii Demianets <vitas@...factor.kiev.ua>
Date: Fri, 2 Nov 2012 19:09:24 +0200

> When underlying phy driver restores its state very fast after being brought 
> down and up so that macb driver function macb_handle_link_change() was never 
> called with link state "down", driver's internal representation of phy speed 
> and duplex (bp->speed and bp->duplex) didn't change. So, macb driver sees no 
> reason to perform actual write to the NCFGR register, although the speed and 
> duplex settings in that register were reset when interface was brought down 
> and up. In that case actual phy speed and duplex differ from NCFGR settings.
> The patch fixes that by keeping internal driver representation of speed and 
> duplex in sync with actual content of NCFGR.
> 
> Signed-off-by: Vitalii Demianets <vitas@...factor.kiev.ua>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html