lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20121104151620.GA2175@netboy.at.omicron.at> Date: Sun, 4 Nov 2012 16:16:20 +0100 From: Richard Cochran <richardcochran@...il.com> To: Cyril Chemparathy <cyril@...com> Cc: netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, David Miller <davem@...emloft.net>, Mugunthan V N <mugunthanvnm@...com>, Vaibhav Hiremath <hvaibhav@...com> Subject: Re: [PATCH net-next 2/2] cpsw: fix leaking IO mappings On Sun, Nov 04, 2012 at 02:23:58PM +0100, Cyril Chemparathy wrote: > On 11/03/2012 09:25 AM, Richard Cochran wrote: > >The CPSW driver remaps two different IO regions, but fails to unmap them > >both. This patch fixes the issue by calling iounmap in the appropriate > >places. > > Any thoughts on using devres helpers to keep the bail out path simpler? I wasn't aware of devres before, but I just read through the doc. It looks interesting, and if I were writting a new driver, then I might use it. But for this driver, it really isn't very complex. It only looks that way, but I think this just accidental. I guess that the code was adapted from the davinci emac driver. Thanks, Richard -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists