netdev - Re: [PATCH net-next 3/3] eth: Rename and properly align br_reserved

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121104124219.561a7235@s6510.linuxnetplumber.net>
Date:	Sun, 4 Nov 2012 12:42:19 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	John Fastabend <john.r.fastabend@...el.com>
Cc:	Ben Hutchings <bhutchings@...arflare.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-net-drivers@...arflare.com
Subject: Re: [PATCH net-next 3/3] eth: Rename and properly align
 br_reserved_address array

On Thu, 01 Nov 2012 17:33:55 -0700
John Fastabend <john.r.fastabend@...el.com> wrote:

> On 11/1/2012 12:12 PM, Ben Hutchings wrote:
> > Since this array is no longer part of the bridge driver, it should
> > have an 'eth' prefix not 'br'.
> >
> > We also assume that either it's 16-bit-aligned or the architecture has
> > efficient unaligned access.  Ensure the first of these is true by
> > explicitly aligning it.
> >
> > Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
> > ---
> 
> Thanks.
> 
> Acked-by: John Fastabend <john.r.fastabend@...el.com>
> 

I wonder if aligning to 64 bit and doing 64 bit read
and mask would be trivially more efficient for this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html