netdev - Re: [PATCH v1 0/5] usbnet: avoiding access auto-suspended device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121105.115010.1531838246984342873.davem@davemloft.net>
Date:	Mon, 05 Nov 2012 11:50:10 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	oneukum@...e.de
Cc:	ming.lei@...onical.com, gregkh@...uxfoundation.org,
	netdev@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v1 0/5] usbnet: avoiding access auto-suspended device

From: Oliver Neukum <oneukum@...e.de>
Date: Mon, 05 Nov 2012 10:24:57 +0100

> On Sunday 04 November 2012 09:29:49 Ming Lei wrote:
>> Thip patchset avoids accessing auto-suspended device in ioctl path,
>> which is generally triggered by some network utility(ethtool, ifconfig,
>> ...)
>> 
>> Most of network devices have the problem, but as discussed in the
>> thread:
>> 
>>         http://marc.info/?t=135054860600003&r=1&w=2
>> 
>> the problem should be solved inside driver.
>> 
>> Considered that only smsc75xx and smsc95xx calls usbnet_read_cmd()
>> and usbnet_write_cmd() inside its resume and suspend callback, the
>> patcheset introduce the nopm version of the two functions which
>> should be called only in the resume and suspend callback. So we
>> can solve the problem by runtime resuming device before doing
>> control message things.
> 
> Hi,
> 
> I am happy with these patches.
> Dave, do you have a principal objection regarding these patches, too?

There were review comments and the most recently posted series
needs to be reposted with that feedback incorporated.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html