netdev - Re: [PATCH V6 0/22] qlcnic: patches for new adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121106.185124.2155177049133289777.davem@davemloft.net>
Date:	Tue, 06 Nov 2012 18:51:24 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sony.chacko@...gic.com
Cc:	netdev@...r.kernel.org, Dept_NX_Linux_NIC_Driver@...gic.com
Subject: Re: [PATCH V6 0/22] qlcnic: patches for new adapter - Qlogic 83XX
 CNA

From: Sony Chacko <sony.chacko@...gic.com>
Date: Mon,  5 Nov 2012 17:11:54 -0500

> I apologize for the above mistake.
> We have fixed the above warning and have verified the rest of the patches.
> Please apply the updated 22 patch series to net-next.

Your changes are still broken:

drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c: In function ‘qlcnic_fw_create_ctx’:
drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c:565:1: warning: the frame size of 8192 bytes is larger than 2048 bytes [-Wframe-larger-than=]

A multi-kilobyte on-stack variable?  Are you kidding me?

This submission is terrible, in every way, shape, and form.  Nobody
wants to review these changes in detail (have you noticed that besides
me, there is zero feedback coming in from anyone).  You have to
recognize that it's demoralizing to review patches when they don't
even build cleanly like your's do.

Stop submitting garbage patches, now.

I want you to not resubmit this for at least a week.  You must
eliminate all of these kinds of problems, you must validate the build,
you must double check everything.

And you cannot be trusted to do that in just one or two days.

Again, don't resubmit this until you've worked over and double checked
everything in it for at least a week.