netdev - Re: [PATCH 1/6] VSOCK: vsock protocol implementation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121106101013.09806f81@s6510.linuxnetplumber.net>
Date:	Tue, 6 Nov 2012 10:10:13 +0100
From:	Stephen Hemminger <shemminger@...tta.com>
To:	George Zhang <georgezhang@...are.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	virtualization@...ts.linux-foundation.org, pv-drivers@...are.com,
	vm-crosstalk@...are.com, davem@...emloft.net,
	gregkh@...uxfoundation.org
Subject: Re: [PATCH 1/6] VSOCK: vsock protocol implementation.

On Mon, 05 Nov 2012 10:00:51 -0800
George Zhang <georgezhang@...are.com> wrote:

> +	/* Added in 2.6.10. */
> +	.owner = THIS_MODULE,

Thanks for submitting this, it will make life easier for distro's
that now have to go through extra effort to include out of mainline
support for Vmware.

You did some scrubbing of the macro's to support multiple kernel
versions, but there are still some leftovers.
This code seems to have a lot of "this added in version xxx"
type comments. These are probably not a good idea to include
in the mainline kernel code. 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html