netdev - Re: [PATCH v3 3/5] usbnet: smsc95xx: fix memory leak in smsc95xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKh2mn52HCFE8JSRJZ95m8qimPP0d4hx8SP3yExTsi+RYfJwRg@mail.gmail.com>
Date:	Tue, 6 Nov 2012 13:20:44 +0000
From:	Steve Glendinning <steve@...well.net>
To:	Ming Lei <ming.lei@...onical.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Oliver Neukum <oneukum@...e.de>,
	netdev <netdev@...r.kernel.org>, linux-usb@...r.kernel.org,
	Steve Glendinning <steve.glendinning@...well.net>
Subject: Re: [PATCH v3 3/5] usbnet: smsc95xx: fix memory leak in smsc95xx_suspend

On 6 November 2012 01:45, Ming Lei <ming.lei@...onical.com> wrote:
> This patch fixes memory leak in smsc95xx_suspend.

Good spot, thanks!

Note that check_warn_return just above your kfree can cause early
return in the error case, which would still leak filter_mask, so we
might want to explicitly expand that instance of the helper macro.

> Also, it isn't necessary to bother mm to allocate 8bytes/16byte,
> and we can use stack variable safely.

Acked-By: Steve Glendinning <steve.glendinning@...well.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html