netdev - Re: net/smsc911x: problems after commit 3ac3546e [Always wait for the chip to be ready]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20121106.123623.676046673605774326.davem@davemloft.net>
Date:	Tue, 06 Nov 2012 12:36:23 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	kamlakant.patel@...adcom.com
Cc:	steve@...well.net, linus.walleij@...aro.org,
	robert.marklund@...ricsson.com, netdev@...r.kernel.org
Subject: Re: net/smsc911x: problems after commit 3ac3546e [Always wait for
 the chip to be ready]

From: "Kamlakant Patel" <kamlakant.patel@...adcom.com>
Date: Tue, 6 Nov 2012 11:16:44 +0530

> The issue is that the logic of the commit 3ac3546e does not work if
> WORD_SWAP is needed. So we have to either revert that commit or add
> logic to check for swapped register if we read PMT_CTRL before
> programming WORD_SWAP.

I understand the problem.

You program the device into a state the driver is not expecting,
you have to therefore undo that before transferring control to
the kernel.

I accept no other solution, testing random reserved bits is
bogus beyond belief.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html