netdev - Re: [PATCH 1/2] net: fec: default select FEC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 Nov 2012 18:58:16 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Frank Li <Frank.Li@...escale.com>
CC:	<lznuaa@...il.com>, <richardcochran@...il.com>,
	<shawn.guo@...aro.org>, <linux-arm-kernel@...ts.infradead.or>,
	<netdev@...r.kernel.org>, <davem@...emloft.net>
Subject: Re: [PATCH 1/2] net: fec: default select FEC_PTP at mx6 platform

On Wed, 2012-11-07 at 14:14 +0800, Frank Li wrote:
> Remove PPS.
> Limit FEC_PTP option for i.MX chip only.
> FEC_PTP default is on at mx6 platform.
> 
> Signed-off-by: Frank Li <Frank.Li@...escale.com>
Acked-by: Ben Hutchings <bhutchings@...arflare.com>

Looks sensible, though I know nothing about the hardware dependencies.

Ben.

> ---
>  drivers/net/ethernet/freescale/Kconfig |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
> index ff3be53..5ba6e1c 100644
> --- a/drivers/net/ethernet/freescale/Kconfig
> +++ b/drivers/net/ethernet/freescale/Kconfig
> @@ -94,9 +94,9 @@ config GIANFAR
>  
>  config FEC_PTP
>  	bool "PTP Hardware Clock (PHC)"
> -	depends on FEC
> -	select PPS
> +	depends on FEC && ARCH_MXC
>  	select PTP_1588_CLOCK
> +	default y if SOC_IMX6Q
>  	--help---
>  	  Say Y here if you want to use PTP Hardware Clock (PHC) in the
>  	  driver.  Only the basic clock operations have been implemented.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html