netdev - Re: [PATCH] gianfar: ethernet vanishes after restoring from hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121109.170859.796967518373395470.davem@davemloft.net>
Date:	Fri, 09 Nov 2012 17:08:59 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	paul.gortmaker@...driver.com
Cc:	netdev@...r.kernel.org, dongsheng.wang@...escale.com,
	claudiu.manoil@...escale.com
Subject: Re: [PATCH] gianfar: ethernet vanishes after restoring from
 hibernation

From: Paul Gortmaker <paul.gortmaker@...driver.com>
Date: Fri,  9 Nov 2012 09:43:51 -0500

> From: Wang Dongsheng <dongsheng.wang@...escale.com>
> 
> If a gianfar ethernet device is down prior to hibernating a
> system, it will no longer be present upon system restore.
> 
> For example:
> 
> 	~# ifconfig eth0 down
> 	~# echo disk > /sys/power/state
> 
> 	  <trigger a restore from hibernation>
> 
> 	~# ifconfig eth0 up
> 	SIOCSIFFLAGS: No such device
> 
> This happens because the restore function bails out early upon
> finding devices that were not up at hibernation.  In doing so,
> it never gets to the netif_device_attach call at the end of
> the restore function.  Adding the netif_device_attach as done
> here also makes the gfar_restore code consistent with what is
> done in the gfar_resume code.
> 
> Cc: Claudiu Manoil <claudiu.manoil@...escale.com>
> Signed-off-by: Wang Dongsheng <dongsheng.wang@...escale.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html