netdev - Re: [PATCH 3/3] ipgre: capture inner headers during encapsulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.02.1211111746450.29318@morpheus.jf.intel.com>
Date:	Sun, 11 Nov 2012 17:47:55 -0800 (PST)
From:	Joseph Gasparakis <joseph.gasparakis@...el.com>
To:	Dmitry Kravkov <dmitry@...adcom.com>
cc:	Joseph Gasparakis <joseph.gasparakis@...el.com>,
	davem@...emloft.net, shemminger@...tta.com, chrisw@...s-sol.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
Subject: Re: [PATCH 3/3] ipgre: capture inner headers during encapsulation



On Sun, 11 Nov 2012, Dmitry Kravkov wrote:

> On Thu, 2012-11-08 at 18:18 -0800, Joseph Gasparakis wrote:
> >  
> >  	if (skb->ip_summed == CHECKSUM_PARTIAL &&
> >  	    skb_checksum_help(skb))
> > @@ -902,6 +903,17 @@ static netdev_tx_t ipgre_tunnel_xmit(struct sk_buff *skb, struct net_device *dev
> >  			tunnel->err_count = 0;
> >  	}
> >  
> > +	offset = skb->data - skb->head;
> > +
> > +	skb_reset_inner_mac_header(skb);
> > +
> > +	if (skb->network_header)
> > +		skb_set_inner_network_header(skb, skb->network_header - offset);
> > +
> > +	if (skb->transport_header)
> > +		skb_set_inner_transport_header(skb, skb->transport_header -
> > +					       offset);
> > +
> >  	max_headroom = LL_RESERVED_SPACE(tdev) + gre_hlen + rt->dst.header_len;
> >  
> >  	if (skb_headroom(skb) < max_headroom || skb_shared(skb)||
> 
> How it will be useful if skb_checksum_help(skb) will calculate csum? And
> leaves nothing to offload 
>
Thanks for catching this Dmitry. Will fix it in v2 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html