netdev - Re: [PATCH] cdc_ether: use USB_DEVICE_AND_INTERFACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1352740459.2314.7.camel@dcbw.foobar.com>
Date:	Mon, 12 Nov 2012 11:14:19 -0600
From:	Dan Williams <dcbw@...hat.com>
To:	David Miller <davem@...emloft.net>
Cc:	bjorn@...k.no, aleksander@....org, netdev@...r.kernel.org
Subject: Re: [PATCH] cdc_ether: use USB_DEVICE_AND_INTERFACE_INFO for
 Novatel 551L/E362

On Fri, 2012-11-09 at 16:07 -0500, David Miller wrote:
> From: Dan Williams <dcbw@...hat.com>
> Date: Thu, 08 Nov 2012 12:09:12 -0600
> 
> > Small cleanup.
> > 
> > Signed-off-by: Dan Williams <dcbw@...hat.com>
> > Cc: stable@...r.kernel.org
> 
> Don't do things like this, _please_.
> 
> A cleanup is absolutely not appropriate for -stable.   Yet you
> tagged this as being destined for there.

Ok.

> What's more this screws up the second patch, which in fact could
> be -stable material.  But I'm not going to apply it as it is
> because it could have dependencies on this patch which as
> states is not inappropriate for both 'net' and -stable.

I did carefully check that the context for the second patch
(qmi_wwan/cdc_ether: add Dell Wireless 5800 (Novatel E362) USB IDs) was
*not* dependent on the first patch.  Hence I did not post them as a
series, but as separate patches, as they should be independently
applicable.

> I'm therefore tossing both of these changes, submit things properly
> please.

I will resubmit both patches, with "qmi_wwan/cdc_ether: add Dell
Wireless 5800 (Novatel E362) USB IDs" cc-ed to stable@, but this patch
(cdc_ether: use USB_DEVICE_AND_INTERFACE_INFO for Novatel 551L/E362)
only for net-next.

Thanks,
Dan

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html