netdev - Re: [PATCHES] Networking fixes for -stable.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1352836286.16264.102.camel@deadeye.wl.decadent.org.uk>
Date:	Tue, 13 Nov 2012 19:51:26 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Miller <davem@...emloft.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Peter Senna Tschudin <peter.senna@...il.com>
Cc:	stable@...r.kernel.org, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCHES] Networking fixes for -stable.

On Mon, 2012-11-12 at 00:25 -0500, David Miller wrote:
> Please queue up the following networking bug fixes for
> 3.0.x, 3.2.x, 3.4.x, and 3.6.x, respectively.
[...]
> From 2204849a85383fbde75680aa199142abe504adbb Mon Sep 17 00:00:00 2001
> From: Peter Senna Tschudin <peter.senna@...il.com>
> Date: Sun, 28 Oct 2012 06:12:01 +0000
> Subject: [PATCH 7/9] drivers/net/phy/mdio-bitbang.c: Call mdiobus_unregister
>  before mdiobus_free
> 
> [ Upstream commit aa731872f7d33dcb8b54dad0cfb82d4e4d195d7e ]
> 
> Based on commit b27393aecf66199f5ddad37c302d3e0cfadbe6c0
> 
> Calling mdiobus_free without calling mdiobus_unregister causes
> BUG_ON(). This patch fixes the issue.
[...]

This introduces a regresssion, as mdiobus_unregister() is not safe to
call if the bus isn't registered.  Registration is controlled by the
drivers that use mdio-bitbang, and they should take care of
unregistration too - and most of them do.

This should be reverted in mainline and not applied to any stable
series.

Ben.

-- 
Ben Hutchings
For every complex problem
there is a solution that is simple, neat, and wrong.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)