netdev - Re: [PATCH net-next 2/2] ARM: net: bpf_jit_32: add VLAN instructions for BPF JIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50A2D114.8080306@gmail.com>
Date:	Wed, 14 Nov 2012 00:00:36 +0100
From:	Mircea Gherzan <mgherzan@...il.com>
To:	Daniel Borkmann <dxchgb@...il.com>
CC:	davem@...emloft.net, Arnd Bergmann <arnd@...db.de>,
	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net-next 2/2] ARM: net: bpf_jit_32: add VLAN instructions
 for BPF JIT

Am 08.11.2012 02:31, schrieb Daniel Borkmann:
> This patch is a follow-up for patch "net: filter: add vlan tag access"
> to support the new VLAN_TAG/VLAN_TAG_PRESENT accessors in BPF JIT.
> 
> Signed-off-by: Daniel Borkmann <daniel.borkmann@....ee.ethz.ch>
> Cc: Mircea Gherzan <mgherzan@...il.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> ---
>  arch/arm/net/bpf_jit_32.c |   14 ++++++++++++++
>  1 files changed, 14 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c
> index 8be702d..9af9a69 100644
> --- a/arch/arm/net/bpf_jit_32.c
> +++ b/arch/arm/net/bpf_jit_32.c
> @@ -16,6 +16,7 @@
>  #include <linux/netdevice.h>
>  #include <linux/string.h>
>  #include <linux/slab.h>
> +#include <linux/if_vlan.h>
>  #include <asm/cacheflush.h>
>  #include <asm/hwcap.h>
>  
> @@ -168,6 +169,8 @@ static inline bool is_load_to_a(u16 inst)
>  	case BPF_S_ANC_MARK:
>  	case BPF_S_ANC_PROTOCOL:
>  	case BPF_S_ANC_RXHASH:
> +	case BPF_S_ANC_VLAN_TAG:
> +	case BPF_S_ANC_VLAN_TAG_PRESENT:
>  	case BPF_S_ANC_QUEUE:
>  		return true;
>  	default:
> @@ -815,6 +818,17 @@ b_epilogue:
>  			off = offsetof(struct sk_buff, rxhash);
>  			emit(ARM_LDR_I(r_A, r_skb, off), ctx);
>  			break;
> +		case BPF_S_ANC_VLAN_TAG:
> +		case BPF_S_ANC_VLAN_TAG_PRESENT:
> +			ctx->seen |= SEEN_SKB;
> +			BUILD_BUG_ON(FIELD_SIZEOF(struct sk_buff, vlan_tci) != 2);
> +			off = offsetof(struct sk_buff, vlan_tci);
> +			emit(ARM_LDRH_I(r_A, r_skb, off), ctx);
> +			if (inst->code == BPF_S_ANC_VLAN_TAG)
> +				OP_IMM3(ARM_AND, r_A, r_A, VLAN_VID_MASK, ctx);
> +			else
> +				OP_IMM3(ARM_AND, r_A, r_A, VLAN_TAG_PRESENT, ctx);
> +			break;
>  		case BPF_S_ANC_QUEUE:
>  			ctx->seen |= SEEN_SKB;
>  			BUILD_BUG_ON(FIELD_SIZEOF(struct sk_buff,

Acked-by: Mircea Gherzan <mgherzan@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html