netdev - Re: [PATCH] vxlan: Update hard_header_len based on lowerdev when instantiating VXLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121113151200.16afce74@nehalam.linuxnetplumber.net>
Date:	Tue, 13 Nov 2012 15:12:00 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Alexander Duyck <alexander.h.duyck@...el.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH] vxlan: Update hard_header_len based on lowerdev when
 instantiating VXLAN

On Tue, 13 Nov 2012 15:10:59 -0800
Alexander Duyck <alexander.h.duyck@...el.com> wrote:

> In the event of a VXLAN device being linked to a device that has a
> hard_header_len greater than that of standard ethernet we could end up with
> the hard_header_len not being large enough for outgoing frames.  In order to
> prevent this we should update the length when a lowerdev is provided.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
> ---
> 
>  drivers/net/vxlan.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 44bcc20..6b666eb 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -1110,6 +1110,10 @@ static int vxlan_newlink(struct net *net, struct net_device *dev,
>  
>  		if (!tb[IFLA_MTU])
>  			dev->mtu = lowerdev->mtu - VXLAN_HEADROOM;
> +
> +		/* update header length based on lower device */
> +		dev->hard_header_len = lowerdev->hard_header_len +
> +				       VXLAN_HEADROOM;
>  	}
>  
>  	if (data[IFLA_VXLAN_TOS])
> 

Acked-by: Stephen Hemminger <shemminger@...tta.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html