netdev - ath9k_htc-based adapter unfunctioning after commit ceb26a6013

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20641.63106.943323.923565@gargle.gargle.HOWL>
Date:	Tue, 13 Nov 2012 12:58:02 +0530
From:	Sujith Manoharan <sujith@...jith.org>
To:	Corey Richardson <corey@...ayn.net>
Cc:	linux-wireless@...r.kernel.org, jouni@....qualcomm.com,
	vthiagar@....qualcomm.com, linville@...driver.com,
	ath9k-devel@...ts.ath9k.org, netdev@...r.kernel.org,
	nbd@...nwrt.org
Subject: ath9k_htc-based adapter unfunctioning after commit ceb26a6013

Corey Richardson wrote:
> I was giving 3.7-rc4 a whirl when I discovered my wireless adapter [0] wasn't
> working: the LED didn't light up. Went and ran 'ip link' and it just hung there.
> Tried a few other things and discovered that sudo was broken too. With
> strace I found that they were hanging in sendto().
> 
> If I then unplug the adapter, everything comes out of the hang.
> 
> Bisected and found that commit ceb26a6013b962b82f644189ea29d802490fc8fc is
> to blame.

I can see this issue too. I am not entirely convinced that the commit in
question is valid. If a HW reset fails for some reason in start(), bailing
out seems the right thing to do instead of continuing to fiddle with the HW
and silently returning a success code to mac80211.

I was able to bring up the device with this patch.

diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
index 756191b..e06bcec 100644
--- a/drivers/net/wireless/ath/ath9k/hw.c
+++ b/drivers/net/wireless/ath/ath9k/hw.c
@@ -1456,7 +1456,7 @@ static bool ath9k_hw_set_reset_reg(struct ath_hw *ah, u32 type)
 	switch (type) {
 	case ATH9K_RESET_POWER_ON:
 		ret = ath9k_hw_set_reset_power_on(ah);
-		if (!ret)
+		if (ret)
 			ah->reset_power_on = true;
 		break;
 	case ATH9K_RESET_WARM:

Sujith
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html