netdev - Re: [RFC PATCH 01/13] net: Add generic packet offload infrastructure.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1352859861.4497.0.camel@edumazet-glaptop>
Date:	Tue, 13 Nov 2012 18:24:21 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Vlad Yasevich <vyasevic@...hat.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.com
Subject: Re: [RFC PATCH 01/13] net:  Add generic packet offload
 infrastructure.

On Tue, 2012-11-13 at 20:24 -0500, Vlad Yasevich wrote:
> Create a new data structure to contain the GRO/GSO callbacks and add
> a new registration mechanism.
> 
> Singed-off-by: Vlad Yasevich <vyasevic@...hat.com>
> ---
>  include/linux/netdevice.h |   15 ++++++++
>  net/core/dev.c            |   80 +++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 95 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index f8eda02..d15af51 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1511,6 +1511,18 @@ struct packet_type {
>  	struct list_head	list;
>  };
>  
> +struct packet_offload {
> +	__be16			type;	/* This is really htons(ether_type). */
> +	struct net_device	*dev;	/* NULL is wildcarded here	     */

Shouldnt this dev pointer be removed at some point in the patch serie ?

> +	struct sk_buff		*(*gso_segment)(struct sk_buff *skb,
> +						netdev_features_t features);
> +	int			(*gso_send_check)(struct sk_buff *skb);
> +	struct sk_buff		**(*gro_receive)(struct sk_buff **head,
> +					       struct sk_buff *skb);
> +	int			(*gro_complete)(struct sk_buff *skb);
> +	struct list_head	list;
> +};
> +
>  #include <linux/notifier.h>
>  

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html