| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20121114152225.GB2531@minipsycho.brq.redhat.com> Date: Wed, 14 Nov 2012 16:22:25 +0100 From: Jiri Pirko <jiri@...nulli.us> To: Eric Dumazet <eric.dumazet@...il.com> Cc: netdev@...r.kernel.org, davem@...emloft.net, shemminger@...tta.com, john.r.fastabend@...el.com Subject: Re: [patch net] net: correct check in dev_addr_del() Wed, Nov 14, 2012 at 03:38:59PM CET, eric.dumazet@...il.com wrote: >On Wed, 2012-11-14 at 15:29 +0100, Jiri Pirko wrote: >> Wed, Nov 14, 2012 at 03:18:35PM CET, eric.dumazet@...il.com wrote: >> >On Wed, 2012-11-14 at 13:51 +0100, Jiri Pirko wrote: >> >> Check (ha->addr == dev->dev_addr) is always true because dev_addr_init() >> >> sets this. Correct the check to behave properly on addr removal. >> >> >> >> Signed-off-by: Jiri Pirko <jiri@...nulli.us> >> >> --- >> > >> >Please add in the changelog which commit added the bug, to ease >> >stable teams work. >> >> bug introduced by: >> >> commit a748ee2426817a95b1f03012d8f339c45c722ae1 >> Author: Jiri Pirko <jpirko@...hat.com> >> Date: Thu Apr 1 21:22:09 2010 +0000 >> >> net: move address list functions to a separate file > >Good, the usual way is then to add in the changelog : > >Bug added in commit a748ee242681 >(net: move address list functions to a separate file) > > >(No need to give the author/date, and we can shorten the SHA1 to 10 or >12 digits) Mind noted. Thanks Eric. > >Thanks > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists