netdev - Re: [PATCH net-next] tunnel: use the correct endian for some fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121115090821.31b41e95@s6510.linuxnetplumber.net>
Date:	Thu, 15 Nov 2012 09:08:21 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Cong Wang <amwang@...hat.com>
Cc:	nicolas.dichtel@...nd.com, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next] tunnel: use the correct endian for some fields

On Thu, 15 Nov 2012 17:04:35 +0800
Cong Wang <amwang@...hat.com> wrote:

> On Thu, 2012-11-15 at 09:57 +0100, Nicolas Dichtel wrote:
> > Le 15/11/2012 09:51, Cong Wang a écrit :
> > > Fengguang reported:
> > >
> > > net/ipv6/ip6_tunnel.c:1571:33: sparse: incorrect type in assignment (different base types)
> > > net/ipv6/ip6_tunnel.c:1571:33:    expected restricted __be32 [usertype] flowinfo
> > > net/ipv6/ip6_tunnel.c:1571:33:    got unsigned int
> > >
> > > for these fields, we need to use the correct endian wrapers.
> > >
> > > Reported-by: Fengguang Wu <fengguang.wu@...el.com>
> > > Cc: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> > > Cc: David S. Miller <davem@...emloft.net>
> > > Signed-off-by: Cong Wang <amwang@...hat.com>
> > Just one minute before my patch.
> > Your patch does not fix all warnings (i_flags & SIT_ISATAP in ip6_tunnel.c).
> 
> Yeah, then ignore this patch. :)

i_flags is a mess right now, it mixed host and bigendian values in the
same field. Also SIT and VTI flags overlap.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html