netdev - Re: [PATCHv2] sctp: fix /proc/net/sctp/ memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87k3tmedvo.fsf@xmission.com>
Date:	Thu, 15 Nov 2012 13:48:43 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Tommi Rantala <tt.rantala@...il.com>
Cc:	netdev@...r.kernel.org, Neil Horman <nhorman@...driver.com>,
	Vlad Yasevich <vyasevich@...il.com>,
	Sridhar Samudrala <sri@...ibm.com>,
	"David S. Miller" <davem@...emloft.net>,
	linux-sctp@...r.kernel.org, Dave Jones <davej@...hat.com>
Subject: Re: [PATCHv2] sctp: fix /proc/net/sctp/ memory leak

Tommi Rantala <tt.rantala@...il.com> writes:

> Commit 13d782f ("sctp: Make the proc files per network namespace.")
> changed the /proc/net/sctp/ struct file_operations opener functions to
> use single_open_net() and seq_open_net().
>
> Avoid leaking memory by using single_release_net() and seq_release_net()
> as the release functions.
>
> Discovered with Trinity (the syscall fuzzer).

Doh!  Thanks for catching this.

Eric

> -	.release = single_release,
> +	.release = single_release_net,
>  };

> -	.release = seq_release,
> +	.release = seq_release_net,
>  };
>  
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html