netdev - Re: [PATCH net-next 1/3] ipip: fix sparse warnings in ipip_netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1352985350.4497.28.camel@edumazet-glaptop>
Date:	Thu, 15 Nov 2012 05:15:50 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-next 1/3] ipip: fix sparse warnings in
 ipip_netlink_parms()

On Thu, 2012-11-15 at 09:53 +0100, Nicolas Dichtel wrote:
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> ---
>  net/ipv4/ipip.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/ipv4/ipip.c b/net/ipv4/ipip.c
> index 64686e1..c26c171 100644
> --- a/net/ipv4/ipip.c
> +++ b/net/ipv4/ipip.c
> @@ -864,10 +864,10 @@ static void ipip_netlink_parms(struct nlattr *data[],
>  		parms->link = nla_get_u32(data[IFLA_IPTUN_LINK]);
>  
>  	if (data[IFLA_IPTUN_LOCAL])
> -		parms->iph.saddr = nla_get_u32(data[IFLA_IPTUN_LOCAL]);
> +		parms->iph.saddr = nla_get_be32(data[IFLA_IPTUN_LOCAL]);
>  
>  	if (data[IFLA_IPTUN_REMOTE])
> -		parms->iph.daddr = nla_get_u32(data[IFLA_IPTUN_REMOTE]);
> +		parms->iph.daddr = nla_get_be32(data[IFLA_IPTUN_REMOTE]);
>  
>  	if (data[IFLA_IPTUN_TTL]) {
>  		parms->iph.ttl = nla_get_u8(data[IFLA_IPTUN_TTL]);


No credit for who reported this bug ?



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html