netdev - Re: [PATCH] tcp: handle tcp_net_metrics_init() order-5 memory allocation failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121116.133711.1809052219019793698.davem@davemloft.net>
Date:	Fri, 16 Nov 2012 13:37:11 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, jln@...gle.com
Subject: Re: [PATCH] tcp: handle tcp_net_metrics_init() order-5 memory
 allocation failures

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 16 Nov 2012 07:31:53 -0800

> Well, we dont really know what the size needs to be, and your proposal
> reduces the size by a 4 factor, even for the initial namespace.
> 
> Julien report was about Chrome browser own netns, on a suspend/resume
> cycle (or something like that)
> 
> If size can influence behavior, we could try a vmalloc() if kmalloc()
> fails...

Agreed.

> [PATCH v3] tcp: handle tcp_net_metrics_init() order-5 memory allocation failures
> 
> order-5 allocations can fail with current kernels, we should
> try vmalloc() as well.
> 
> Reported-by: Julien Tinnes <jln@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

This looks great, applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html