[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1353351459.4156.5.camel@bwh-desktop.uk.solarflarecom.com>
Date: Mon, 19 Nov 2012 18:57:39 +0000
From: Ben Hutchings <bhutchings@...arflare.com>
To: "Maciej W. Rozycki" <macro@...ux-mips.org>
CC: Bill Pemberton <wfp5p@...ginia.edu>, <gregkh@...uxfoundation.org>,
<netdev@...r.kernel.org>
Subject: Re: [PATCH 080/493] fddi: remove use of __devexit_p
On Mon, 2012-11-19 at 18:49 +0000, Maciej W. Rozycki wrote:
> On Mon, 19 Nov 2012, Bill Pemberton wrote:
>
> > CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
> > needed.
>
> Shouldn't this be switching to __exit_p() instead? Likewise all the
> other changes concerned (i.e. s/__dev\(init\|exit\)/__\1/), for the sake
> of drivers built into the kernel proper (yes, there are people out there
> still doing that). Am I missing something?
Drivers can be unbound by poking in sysfs.
Ben.
> This change scores my NAK as it stands, until updated accordingly or
> further justified.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists