netdev - RE: [PATCH] ixgbe: fix broken PPTP handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Nov 2012 17:12:17 +0000
From:	"Vick, Matthew" <matthew.vick@...el.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>
Subject: RE: [PATCH] ixgbe: fix broken PPTP handling

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-
> owner@...r.kernel.org] On Behalf Of Alan Cox
> Sent: Tuesday, November 20, 2012 8:33 AM
> To: netdev@...r.kernel.org
> Subject: [PATCH] ixgbe: fix broken PPTP handling
> 
> From: Alan Cox <alan@...ux.intel.com>
> 
> Reported to the maintain 3 weeks ago so now sending a patch rather than
> waiting. ixgbe passes a random event type to the pptp code
> 
> Signed-off-by: Alan Cox <alan@...ux.intel.com>
> ---
> 
>  drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c
> b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c
> index 01d99af..73291fe 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c
> @@ -398,6 +398,7 @@ void ixgbe_ptp_check_pps_event(struct ixgbe_adapter
> *adapter, u32 eicr)
> 
>  	switch (hw->mac.type) {
>  	case ixgbe_mac_X540:
> +		event.type = PTP_CLOCK_PPS;
>  		ptp_clock_event(adapter->ptp_clock, &event);
>  		break;
>  	default:

CCing e1000-devel, the mailing list for Intel Wired Ethernet support.

Sorry, Alan--I didn't see any message from you about this before or I would have responded. NAK on this, since I don't see how ixgbe is passing a random event type. The event type gets set to PTP_CLOCK_PPS just a few lines above (before the if (!adapter->ptp_clock) block).

Matthew