netdev - Re: team: add broadcast mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121121093658.GA1629@minipsycho.orion>
Date:	Wed, 21 Nov 2012 10:36:58 +0100
From:	Jiri Pirko <jiri@...nulli.us>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	jpirko@...hat.com, netdev@...r.kernel.org
Subject: Re: team: add broadcast mode

Tue, Nov 20, 2012 at 08:23:07PM CET, dan.carpenter@...cle.com wrote:
>Hello Jiri Pirko,
>
>The patch 5fc889911a99: "team: add broadcast mode" from Jul 11, 2012, 
>leads to the following Smatch warning:
>drivers/net/team/team_mode_broadcast.c:46 bc_transmit()
>	 warn: signedness bug returning '18446744073709551516'
>
>The error message sucks because 18446744073709551516 is -100 as an int,
>and I'm not sure how it figures this returns -100...
>
>But actually there is a signedness bug in bc_transmit().  We return
>error codes from team_dev_queue_xmit() and cast them to 1 as bool.  This
>function is supposed to return 1 on success but instead it returns zero.


Thanks Dan for finding this. You are correct.                            
I'm going to send patch introducing "!" in front of both
team_dev_queue_xmit() calls in bc_transmit(). That will correct this.                          
	                                                                         
Jiri 

>
>regards,
>dan carpenter
>
>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html