netdev - Re: [Suggestion] net/netfilter: strcpy for timeout->name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121121113901.GA25102@breakpoint.cc>
Date:	Wed, 21 Nov 2012 12:39:01 +0100
From:	Florian Westphal <fw@...len.de>
To:	Chen Gang <gang.chen@...anux.com>
Cc:	Xue Ying <ying.xue0@...il.com>, David Miller <davem@...emloft.net>,
	Shan Wei <shanwei88@...il.com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [Suggestion] net/netfilter: strcpy for timeout->name

Chen Gang <gang.chen@...anux.com> wrote:
> Please help checking net/netfilter/nfnetlink_cttimeout.c:
>   I suggest, we use strncpy instead of strcpy at line 143. 
>   just like we have already used strncmp at line 94.
[..]
>   after checking the calling work flow:
>     the length of nla_data(cda[CTA_TIMEOUT_NAME]) is not limited in server side.

Good catch, classic buffer overflow.

I've sent a patch to add the missing "len" policy.  Thanks for reporting
this bug.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html