netdev - Re: [PATCH net 1/1] 8139cp: revert "set ring address before enabling receiver"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121121.233901.947301057462707828.davem@davemloft.net>
Date:	Wed, 21 Nov 2012 23:39:01 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jgarzik@...ox.com
Cc:	romieu@...zoreil.com, netdev@...r.kernel.org, dwmw2@...radead.org,
	jasowang@...hat.com, gilboad@...il.com
Subject: Re: [PATCH net 1/1] 8139cp: revert "set ring address before
 enabling receiver"

From: Jeff Garzik <jgarzik@...ox.com>
Date: Wed, 21 Nov 2012 22:44:02 -0500

> On 11/21/2012 03:07 PM, Francois Romieu wrote:
>> This patch reverts b01af4579ec41f48e9b9c774e70bd6474ad210db.
>>
>> The original patch was tested with emulated hardware. Real
>> hardware chokes.
>>
>> Fixes https://bugzilla.kernel.org/show_bug.cgi?id=47041
>>
>> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> 
> Acked-by: Jeff Garzik <jgarzik@...hat.com>

I'm definitely not applying the revert, because it hurts the largest
user of this driver, which is the virtual hardware.

David Woodhouse's patch is the only reasonable way forward at this
point, so I'd apprecite it if you'd give his patch a review too.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html