netdev - Re: [PATCH 9/9] batman-adv: Use packing of 2 for all headers before an ethernet header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3602626.rWyvU1cq5r@bentobox>
Date:	Thu, 22 Nov 2012 09:28:36 +0100
From:	Sven Eckelmann <sven@...fation.org>
To:	Kevin Curtis <Kevin.Curtis@...site.com>
Cc:	David Miller <davem@...emloft.net>,
	"ordex@...istici.org" <ordex@...istici.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"b.a.t.m.a.n@...ts.open-mesh.org" <b.a.t.m.a.n@...ts.open-mesh.org>,
	"lindner_marek@...oo.de" <lindner_marek@...oo.de>,
	"linux-driver@...gic.com" <linux-driver@...gic.com>,
	"ron.mercer@...gic.com" <ron.mercer@...gic.com>,
	"jitendra.kalsaria@...gic.com" <jitendra.kalsaria@...gic.com>,
	"rmody@...cade.com" <rmody@...cade.com>,
	"andy@...yhouse.net" <andy@...yhouse.net>,
	"fubar@...ibm.com" <fubar@...ibm.com>
Subject: Re: [PATCH 9/9] batman-adv: Use packing of 2 for all headers before an ethernet header

On Thursday 22 November 2012 08:12:38 Kevin Curtis wrote:
> >> Agree. But we should get this message also to the other guys
> 
> What message would this be?
> Are you advocating a different use of #pragma pack()?

David started this discussion and his statement was:

> The __packed attribute is an abstraction of the actual syntax the 
> compiler uses, if it is supported at all.
> 
> Therefore, you can't just unconditionally use the #pragma, and you 
> would need to use some kind of similar compiler abstraction for it.

So yes, it sounds to me like "don't use #pragma but think about some 
abstraction".

Kind regards,
	Sven
Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)