netdev - Re: [PATCH 2/2] smsc95xx: support PHY wakeup source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKh2mn79sEKVRUe-QGLNv2Jqfuj0eS9PVwrcLiTp7zJxmA1T8A@mail.gmail.com>
Date:	Thu, 22 Nov 2012 12:03:44 +0000
From:	Steve Glendinning <steve@...well.net>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 2/2] smsc95xx: support PHY wakeup source

>> +{
>> +     struct mii_if_info *mii = &dev->mii;
>> +
>> +        /* first, a dummy read, needed to latch some MII phys */
>> +     int ret = smsc95xx_mdio_read_nopm(dev->net, mii->phy_id, MII_BMSR);
>
> Please keep the local variable declarations together at the beginning
> of the basic block, don't intermix empty lines and comments as you
> are doing here.

Thanks David, please drop these two patches.  I'll fix these points up
and re-submit.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html