netdev - Re: [PATCH] 8139cp: re-enable interrupts after tx timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121124225855.GA17340@electric-eye.fr.zoreil.com>
Date:	Sat, 24 Nov 2012 23:58:55 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	netdev@...r.kernel.org, jasowang@...hat.com, gilboad@...il.com,
	jgarzik@...hat.com
Subject: Re: [PATCH] 8139cp: re-enable interrupts after tx timeout

David Woodhouse <dwmw2@...radead.org> :
> Recovery doesn't work too well if we leave interrupts disabled...
> 
> Signed-off-by: David Woodhouse <David.Woodhouse@...el.com>

Acked-by: Francois Romieu <romieu@...zoreil.com>

While you are at it, do you see what would prevent the watchdog
timer and the rx napi handler to race on two different CPUs
("using a Geode" could be an answer :o) ) ?

> ---
> For stable too, I suppose.

Yes. Watch for http://patchwork.ozlabs.org/bundle/davem/stable/

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html