netdev - Re: [PATCH] arping: Fix find_device_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50B335B9.1080209@redhat.com>
Date:	Mon, 26 Nov 2012 10:26:17 +0100
From:	Jan Synacek <jsynacek@...hat.com>
To:	yoshfuji@...ux-ipv6.org
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH] arping: Fix find_device_by_ifaddrs()

On 11/22/2012 09:51 AM, Jan Synacek wrote:
> Look for another device if the device name and the currently found one are the
> same, not different.
> 
> Also, make checking for the device's flags nonfatal.
> 
> Signed-off-by: Jan Synacek <jsynacek@...hat.com>
> ---
>  arping.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arping.c b/arping.c
> index ff77bec..d0edccf 100644
> --- a/arping.c
> +++ b/arping.c
> @@ -550,10 +550,10 @@ static int find_device_by_ifaddrs(void)
>  			continue;
>  		if (ifa->ifa_addr->sa_family != AF_PACKET)
>  			continue;
> -		if (device.name && ifa->ifa_name && strcmp(ifa->ifa_name, device.name))
> +		if (device.name && ifa->ifa_name && !strcmp(ifa->ifa_name, device.name))
>  			continue;
>  
> -		if (check_ifflags(ifa->ifa_flags, device.name != NULL) < 0)
> +		if (check_ifflags(ifa->ifa_flags, 0) < 0)
>  			continue;
>  
>  		if (!((struct sockaddr_ll *)ifa->ifa_addr)->sll_halen)
> 

Please, disregard this patch. I found a problem with it and will send a proper
patch soon.

Cheers,

-- 
Jan Synacek
Software Engineer, BaseOS team Brno, Red Hat
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html