netdev - Re: [PATCH net-next:master 20/25] net/dsa: make DSA tagging depend on NETDEVICES and !S390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1353956255.2717.1.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Mon, 26 Nov 2012 18:57:35 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Randy Dunlap <rdunlap@...radead.org>
CC:	Viresh Kumar <viresh.kumar@...aro.org>,
	kbuild test robot <fengguang.wu@...el.com>,
	<davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next:master 20/25] net/dsa: make DSA tagging depend
 on NETDEVICES and !S390

On Mon, 2012-11-26 at 10:50 -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Fix kconfig dependency warning by making DSA support depend on the
> same kconfig symbols that NET_DSA depend on.
> 
> warning: (NET_DSA_TAG_DSA && NET_DSA_TAG_EDSA && NET_DSA_TAG_TRAILER) selects NET_DSA which has unmet direct dependencies (NET && NETDEVICES && !S390)

This perhaps ought to be abstracted into a HAVE_NET_DSA rather than
reepated here.  Also, in net-next NET_DSA still depends on EXPERIMENTAL,
which should be removed.

Ben.

> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> ---
>  net/dsa/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20121126.orig/net/dsa/Kconfig
> +++ linux-next-20121126/net/dsa/Kconfig
> @@ -9,6 +9,7 @@ config NET_DSA
>  
> 
>  menu "Distributed Switch Architecture support"
> +	depends on NETDEVICES && !S390
>  
>  # tagging formats
>  config NET_DSA_TAG_DSA

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html