netdev - Re: [PATCH v3 net-next] sockopt: Change getsockopt() of SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1354048479.2701.21.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Tue, 27 Nov 2012 20:34:39 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Brian Haley <brian.haley@...com>
CC:	David Miller <davem@...emloft.net>,
	Pavel Emelyanov <xemul@...allels.com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 net-next] sockopt: Change getsockopt() of
 SO_BINDTODEVICE to return an interface name

On Mon, 2012-11-26 at 10:21 -0500, Brian Haley wrote:
> Instead of having the getsockopt() of SO_BINDTODEVICE return an index, which
> will then require another call like if_indextoname() to get the actual interface
> name, have it return the name directly.
> 
> This also matches the existing man page description on socket(7) which mentions
> the argument being an interface name.
> 
> If the value has not been set, zero is returned and optlen will be set to zero
> to indicate there is no interface name present.
> 
> Added a seqlock to protect this code path, and dev_ifname(), from someone
> changing the device name via dev_change_name().
> 
> v2: Added seqlock protection while copying device name.
> 
> v3: Fixed word wrap in patch.
> 
> Signed-off-by: Brian Haley <brian.haley@...com>
[...]

Reviewed-by: Ben Hutchings <bhutchings@...arflare.com>

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html