netdev - Re: [PATCH net-next] net: move inet_dport/inet_num in sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1354051401.14302.40.camel@edumazet-glaptop>
Date:	Tue, 27 Nov 2012 13:23:21 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Ling Ma <ling.ma.program@...il.com>
Subject: Re: [PATCH net-next] net: move inet_dport/inet_num in sock_common

On Tue, 2012-11-27 at 19:05 +0000, Ben Hutchings wrote:
> On Tue, 2012-11-27 at 07:06 -0800, Eric Dumazet wrote:

> >  struct sock_common {
> > -	/* skc_daddr and skc_rcv_saddr must be grouped :
> > -	 * cf INET_MATCH() and INET_TW_MATCH()
> > +	/* skc_daddr and skc_rcv_saddr must be grouped on a 8 bytes aligned
> > +	 * address on 64bit arches : cf INET_MATCH() and INET_TW_MATCH()
> 
> __aligned(8)?

Nope, only on 64 bit this requirement exists (since a long time)

I am not sure we want complexity on this.

And we dont want holes to be automatically added here neither.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html