lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Nov 2012 13:19:35 +0100 From: Jan Synacek <jsynacek@...hat.com> To: yoshfuji@...ux-ipv6.org Cc: netdev@...r.kernel.org, Jan Synacek <jsynacek@...hat.com> Subject: [PATCH 2/2] arping: Call usage() before limiting capabilities. Otherwise, running arping binary without the capabilities set results in printing warnings with the usage. Signed-off-by: Jan Synacek <jsynacek@...hat.com> --- arping.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/arping.c b/arping.c index ccb68a0..02e3d9c 100644 --- a/arping.c +++ b/arping.c @@ -959,19 +959,6 @@ main(int argc, char **argv) int socket_errno; int ch; - limit_capabilities(); - -#ifdef USE_IDN - setlocale(LC_ALL, ""); -#endif - - enable_capability_raw(); - - s = socket(PF_PACKET, SOCK_DGRAM, 0); - socket_errno = errno; - - disable_capability_raw(); - while ((ch = getopt(argc, argv, "h?bfDUAqc:w:s:I:V")) != EOF) { switch(ch) { case 'b': @@ -1023,6 +1010,19 @@ main(int argc, char **argv) target = *argv; + limit_capabilities(); + +#ifdef USE_IDN + setlocale(LC_ALL, ""); +#endif + + enable_capability_raw(); + + s = socket(PF_PACKET, SOCK_DGRAM, 0); + socket_errno = errno; + + disable_capability_raw(); + if (device.name && !*device.name) device.name = NULL; -- 1.7.11.7 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists