netdev - Re: [patch] atm: forever loop loading ambassador firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121128104044.785f1041@thirdoffive.cmf.nrl.navy.mil>
Date:	Wed, 28 Nov 2012 10:40:44 -0500
From:	chas williams - CONTRACTOR <chas@....nrl.navy.mil>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] atm: forever loop loading ambassador firmware

On Tue, 27 Nov 2012 20:29:35 +0300
Dan Carpenter <dan.carpenter@...cle.com> wrote:

> There was a forever loop introduced here when we converted this to
> request_firmware() back in 2008.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

This certainly does seem to be the case.

Acked-by: Chas Williams <chas@....nrl.navy.mil>

> ---
> Spotted in code reading.  Untested.
> 
> diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
> index 89b30f3..ff7bb8a 100644
> --- a/drivers/atm/ambassador.c
> +++ b/drivers/atm/ambassador.c
> @@ -1961,6 +1961,7 @@ static int __devinit ucode_init (loader_block * lb, amb_dev * dev) {
>      res = loader_verify(lb, dev, rec);
>      if (res)
>        break;
> +    rec = ihex_next_binrec(rec);
>    }
>    release_firmware(fw);
>    if (!res)
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html