netdev - Re: [PATCH] atm: introduce vcc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121128165906.05ef5e2b@thirdoffive.cmf.nrl.navy.mil>
Date:	Wed, 28 Nov 2012 16:59:06 -0500
From:	chas williams - CONTRACTOR <chas@....nrl.navy.mil>
To:	Krzysztof Mazur <krzysiek@...lesie.net>
Cc:	David Woodhouse <dwmw2@...radead.org>, davem@...emloft.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] atm: introduce vcc_pop()

On Wed, 28 Nov 2012 22:45:34 +0100
Krzysztof Mazur <krzysiek@...lesie.net> wrote:

> On Wed, Nov 28, 2012 at 04:20:01PM -0500, chas williams - CONTRACTOR wrote:
> > i dont like the vcc->pop() implementation and at one point i had the
> > crazy idea of using skb->destructors to handle it.  however, i think it
> > would be necessary to clone the skb's so any existing destructor is
> > preserved.
> 
> With this patch we will kill vcc->pop() in drivers and in future
> we can do that without changes in drivers.

ok

> > 
> > > +#define vcc_pop(vcc, skb) vcc_pop_any(vcc, skb)
> > > +#define vcc_pop_irq(vcc, skb) vcc_pop_any(vcc, skb)
> > 
> > don't define these if you dont plan on using them anway.
> 
> I removed them. I also added check if vcc is NULL, as David Woodhouse
> suggested, some drivers use that.

it should probably be if (likely(vcc) && likely(vcc->pop)) since it
will almost always be the case.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html