netdev - Re: Fwd: Re: [PATCH] net: ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50B5A72D.6070107@asianux.com>
Date:	Wed, 28 Nov 2012 13:54:53 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Shan Wei <shanwei88@...il.com>
CC:	Eric Dumazet <eric.dumazet@...il.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: Fwd: Re: [PATCH] net: ipv6: change %8s to %s for rt->dst.dev->name
 in seq_printf of rt6_info_route


completion: "8 right alignment should not belong to os api level"
  for api, we need keep as fewer contents as we can.
  for output format api: "contents"+"topology"+"separator mark"+"space redundancy" are enough.
  so "8 right alignment" should not belong to api level (it only belongs to "User Experience").


  "User Experience" is most likely 'beautiful' !!

  !-)


gchen.


于 2012年11月27日 13:52, Chen Gang 写道:
> 于 2012年11月27日 13:40, Chen Gang 写道:
>>
>> and now, I think:
>>   A) both input and output through /proc/* are for os api level.
>>   B) but both %8s and %s do not change the output interface format (including contents, topology, separator mark, space redundancy).
>>   C) so it is belong to 'User Experience', not belong to os api.
>>
>>   welcome any another members to giving suggestions and completions.
>>
>>   thanks.
>>
>>   :-)
>>
> 
>   completion: 8 right alignment is not belong to interface format.
>     if it was belong to interface format,
>     it would cause correctness issue (the name len may be larger than 8).
>     so if "8 right alignment" is belong to os api, it means the api is not correct, need change.
> 
>   :-)
> 


-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html