netdev - Re: [PATCH][RESEND] bonding: delete migrated IP addresses from the rlb hash table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121128143853.GA2485@midget.suse.cz>
Date:	Wed, 28 Nov 2012 15:38:53 +0100
From:	Jiri Bohac <jbohac@...e.cz>
To:	Jay Vosburgh <fubar@...ibm.com>
Cc:	Jiri Bohac <jbohac@...e.cz>, Andy Gospodarek <andy@...yhouse.net>,
	netdev@...r.kernel.org
Subject: Re: [PATCH][RESEND] bonding: delete migrated IP addresses from the
 rlb hash table

On Tue, Nov 27, 2012 at 05:05:25PM -0800, Jay Vosburgh wrote:
> Jiri Bohac <jbohac@...e.cz> wrote:

> >Were there any results of your testing?  Good or bad?
> 
> 	I did test it quite a bit (and then neglected to follow up).  I
> tried various deliberate hash collisions to try and make it fail in a
> corner case, but was unable to induce incorrect behavior.

Thanks for the review!

> 	The only issue I see is that a number of added lines run past 80
> columns, e.g.,
> 
> +		if (!(client_info->assigned && client_info->ip_src == arp->ip_src)) {
> +			/* ip_src is going to be updated, fix the src hash list */
> +			u32 hash_src = _simple_hash((u8 *)&arp->ip_src, sizeof(arp->ip_src));
> 
> +	 * sending out client updates with this IP address and the old MAC address.
> 
> +	for (; hash_index != RLB_NULL_INDEX; hash_index = client_info->used_next) {
> 
> 	... and so on. 

I'll re-send a new version with all the >80 column lines fixed.

> I did not compile and test this version, just
> applied it and inspected it; presumably it is functionally identical to
> the prior version. 

Yes, it's identical, only the comments and formatting changed.

> There's also one typo I noted near the end of the
> patch.

Fixed as well. Thanks!


-- 
Jiri Bohac <jbohac@...e.cz>
SUSE Labs, SUSE CZ

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html