netdev - Re: [PATCH 2/3] smsc95xx: fix error handling in suspend failure case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121128.210441.347806091375937919.davem@davemloft.net>
Date:	Wed, 28 Nov 2012 21:04:41 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	steve.glendinning@...well.net
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] smsc95xx: fix error handling in suspend failure
 case

From: Steve Glendinning <steve.glendinning@...well.net>
Date: Wed, 28 Nov 2012 17:46:58 +0000

> -		check_warn_return(ret, "Error reading WUCSR\n");
> +		check_warn_goto_done(ret, "Error reading WUCSR\n");

This is just another example of how error prone these macros
are, kill them.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html