netdev - Re: [PATCH v3] bonding: make arp_ip_target parameter checks consistent with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13894.1354210749@death.nxdomain>
Date:	Thu, 29 Nov 2012 09:39:09 -0800
From:	Jay Vosburgh <fubar@...ibm.com>
To:	Nikolay Aleksandrov <nikolay@...hat.com>
cc:	netdev@...r.kernel.org, andy@...yhouse.net, davem@...emloft.net
Subject: Re: [PATCH v3] bonding: make arp_ip_target parameter checks consistent with sysfs

Nikolay Aleksandrov <nikolay@...hat.com> wrote:

> The module can be loaded with arp_ip_target="255.255.255.255" which makes
> it impossible to remove as the function in sysfs checks for that value,
> so we make the parameter checks consistent with sysfs.
>
> v2: Fix formatting
> v3: Make description text < 75 columns
>
>Signed-off-by: Nikolay Aleksandrov <nikolay@...hat.com>

Signed-off-by: Jay Vosburgh <fubar@...ibm.com>

>---
> drivers/net/bonding/bond_main.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index 5f5b69f..d29159a 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -4706,12 +4706,13 @@ static int bond_check_params(struct bond_params *params)
> 	     arp_ip_count++) {
> 		/* not complete check, but should be good enough to
> 		   catch mistakes */
>-		if (!isdigit(arp_ip_target[arp_ip_count][0])) {
>+		__be32 ip = in_aton(arp_ip_target[arp_ip_count]);
>+		if (!isdigit(arp_ip_target[arp_ip_count][0]) ||
>+		    ip == 0 || ip == htonl(INADDR_BROADCAST)) {
> 			pr_warning("Warning: bad arp_ip_target module parameter (%s), ARP monitoring will not be performed\n",
> 				   arp_ip_target[arp_ip_count]);
> 			arp_interval = 0;
> 		} else {
>-			__be32 ip = in_aton(arp_ip_target[arp_ip_count]);
> 			arp_target[arp_ip_count] = ip;
> 		}
> 	}
>-- 
>1.7.11.7
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html