netdev - [PATCH v3 resend net-next 0/2] myri10ge: LRO to GRO conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1354300319-30771-1-git-send-email-gallatin@myri.com>
Date:	Fri, 30 Nov 2012 13:31:57 -0500
From:	Andrew Gallatin <gallatin@...i.com>
To:	davem@...emloft.net
Cc:	netdev@...r.kernel.org, Andrew Gallatin <gallatin@...i.com>
Subject: [PATCH v3 resend net-next 0/2] myri10ge: LRO to GRO conversion

Hi,

I'm resending this after fixing email client issues.

The following patchset is a resubmission of '[PATCH resend net-next 0/3]
myri10ge: LRO to GRO conversion', and converts myri10ge from using
the old inet_lro interface to GRO, and to do vlan tag decap in
the driver so as to not suffer a performance penalty for vlan
tagged traffic due to the conversion.

Changes this time are:

- Clean up some messy indenting & parens in
  "2/3 myri10ge-Add-vlan-rx-for-better-GRO-perf"
  and store the vlan hdr csum in a variable, so now we are not calling
  csum_partial() nested so deeply it spreads across 3 lines

- Folded 3/3 myri10ge-Use-skb_fill_page_desc into 1/3
  myri10ge-Convert-from-LRO-to-GRO.patch since it is really just small
  part of the LRO removal cleanup.  It was originally a separate patch
  because I noticed the cleanup at the last second, and was too lazy
  to fold it into the first patch where it belonged.

Note that a naive LRO->GRO conversion of myri10ge will result in a
performance regression for vlan tagged frames.  This is because
myri10ge does not offer hardware vlan tag offload, and because GRO
requires hardware vlan tag offload to aggregate vlan tagged frames.

To address this performance regression, I have implemented vlan tag
popping in the myri10ge driver, as it seems to be the lesser of two
evils.  As eric.dumazet@...il.com commented when I asked about this on
netdev: "Given GRO assumes NIC does hardware vlan
offloading, I guess I would chose to do that.  It seems unfortunate to
add vlan decap in GRO path, already very complex." 

Andrew Gallatin (2):
  myri10ge: Convert from LRO to GRO
  myri10ge: Add vlan rx for better GRO perf.

 drivers/net/ethernet/myricom/Kconfig             |    1 -
 drivers/net/ethernet/myricom/myri10ge/myri10ge.c |  275 ++++++----------------
 2 files changed, 74 insertions(+), 202 deletions(-)

-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html