[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20121201114401.GA3989@electric-eye.fr.zoreil.com>
Date: Sat, 1 Dec 2012 12:44:01 +0100
From: Francois Romieu <romieu@...zoreil.com>
To: Wang YanQing <udknight@...il.com>, nic_swsd@...ltek.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3]realtek:r8169: Bugfix or workaround for missing extended GigaMAC registers settings
Wang YanQing <udknight@...il.com> :
[...]
> @@ -6903,6 +6903,14 @@ rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> dev->dev_addr[i] = RTL_R8(MAC0 + i);
> memcpy(dev->perm_addr, dev->dev_addr, dev->addr_len);
>
> + /*
> + *This is a fix for BIOS forget to set
> + *extend GigaMAC registers
> + *Wang YanQing 12/1/2012
> + */
This part will go into the changelog.
> + if (tp->mac_version == RTL_GIGA_MAC_VER_34) {
> + rtl_rar_set(tp, dev->dev_addr);
> + }
rtl_rar_set already includes a RTL_GIGA_MAC_VER_34 test and non-8168evl
devices are already able to stand an extra MAC{0, 4} write. I'll check
it does not hurt on different 81xx devices and submit an update.
Thanks.
--
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists