netdev - Re: [PATCH net-next v1 3/3] net/mlx4_en: Set number of rx/tx channels using ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121201.112555.1561917161372059709.davem@davemloft.net>
Date:	Sat, 01 Dec 2012 11:25:55 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	or.gerlitz@...il.com
Cc:	bhutchings@...arflare.com, amirv@...lanox.com,
	ogerlitz@...lanox.com, oren@...lanox.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v1 3/3] net/mlx4_en: Set number of rx/tx
 channels using ethtool

From: Or Gerlitz <or.gerlitz@...il.com>
Date: Sat, 1 Dec 2012 17:50:09 +0200

> On Sat, Dec 1, 2012 at 1:58 AM, Ben Hutchings <bhutchings@...arflare.com> wrote:
>>
>> The values of max_tx and max_rx are passed in from userland, so you
>> can't trust them.
> 
> Is this a general statement re ethtool values passed from user space
> or something specific here? can't one assume that the ethtool process
> runs under the appropriate admin permission?

He's saying that you need to carefully validate the arguments, not
that appropriate permissions haven't been checked.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html