netdev - Re: [RFT PATCH] 8139cp: properly support change of MTU values [v2]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121203.135200.1242505353532930826.davem@davemloft.net>
Date:	Mon, 03 Dec 2012 13:52:00 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jogreene@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: [RFT PATCH] 8139cp: properly support change of MTU values [v2]

From: John Greene <jogreene@...hat.com>
Date: Mon,  3 Dec 2012 11:19:33 -0500

> The 8139cp driver has a change_mtu function that has not been
> enabled since the dawn of the git repository. However, the
> generic eth_change_mtu is not used in its place, so that
> invalid MTU values can be set on the interface.
> 
> Original patch salvages the broken code for the single case of
> setting the MTU while the interface is down, which is safe
> and also includes the range check.  Now enhanced to support up
> or down interface.
> 
> v2: fix case where rxbufsz isn't changed in the up state case
> 
> Original patch from
> http://lkml.indiana.edu/hypermail/linux/kernel/1202.2/00770.html
> 
> Testing: has been test on virtual 8139cp setup without issue,
> have no access real hardware 8139cp, need testing help.
> 
> Signed-off-by: "John Greene" <jogreene@...hat.com>

I've applied this to net-next, if it triggers any problems we have
some time to work it out before 3.8 is released.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html