netdev - Re: sky2: fix cleanup sequence in probe() function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121203.135304.402769242967325322.davem@davemloft.net>
Date:	Mon, 03 Dec 2012 13:53:04 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	LinoSanfilippo@....de
Cc:	shemminger@...tta.com, mlindner@...vell.com, netdev@...r.kernel.org
Subject: Re: sky2: fix cleanup sequence in probe() function

From: Lino Sanfilippo <LinoSanfilippo@....de>
Date: Sat, 1 Dec 2012 13:39:28 +0100

> The cleanup sequence in sky2_probe() that is called in case of an error is
> mixed up in different places:
> 
> - pci_disable_device() is not called in each case the device has been enabled
> before
> 
> - same for pci_disable_msi(): test_msi() may return with an error != EOPNOTSUPP
> (due to failure of request_irq()). In that case msi is not disabled
> 
> - also failure of register_netdev() does not disable msi
> 
> This patch fixes the concerning parts.
> 
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@....de>

This looks clearly correct to me, so I've applied it to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html