netdev - Re: [net-next:master 98/98] drivers/net/ethernet/myricom/myri10ge/myri10ge.c:1286:34: sparse: cast to restricted _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANeU7QkzUPksHvEL17sUbTezLGNHgMmUFvfyQcX39hEOuyufqQ@mail.gmail.com>
Date:	Mon, 3 Dec 2012 12:13:44 -0800
From:	Christopher Li <sparse@...isli.org>
To:	Andrew Gallatin <gallatin@...i.com>
Cc:	Fengguang Wu <fengguang.wu@...el.com>, netdev@...r.kernel.org,
	Stephen Hemminger <shemminger@...tta.com>
Subject: Re: [net-next:master 98/98] drivers/net/ethernet/myricom/myri10ge/myri10ge.c:1286:34:
 sparse: cast to restricted __be16

On Mon, Dec 3, 2012 at 11:21 AM, Andrew Gallatin <gallatin@...i.com> wrote:
> drivers/net/ethernet/myricom/myri10ge/myri10ge.c:1434:35: warning:
> context imbalance in 'myri10ge_intr' - different lock contexts for basic
> block
>
> Which is apparently triggered by using __netif_tx_trylock().
> Is there something I'm missing, or does sparse just not like
> __netif_tx_trylock() because it divides spinlock acquisition and
> release into 2 different functions?
>

Right. Sparse currently does not have cross function analyse.
It will complain if the lock is not balanced with lock split into
different functions.

Chris
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html