netdev - Question about locking in ndisc.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 4 Dec 2012 12:52:08 -0800
From:	Paul Marks <pmarks@...gle.com>
To:	netdev@...r.kernel.org
Subject: Question about locking in ndisc.c

I've been reading through net/ipv6/ndisc.c recently (trying to
determine if it'd be feasible to implement RFC6724 Rule 5.5), and I'm
confused by the lack of visible locking in the
ndisc_router_discovery() function.

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=net/ipv6/ndisc.c;h=2edce30ef7338cdf1916eef98b353c7dbbc7bcda;hb=HEAD#l1048

There are values written all over the place, for example:
- in6_dev->if_flags
- neigh->flags
- rt->rt6i_flags
- in6_dev->nd_parms->...
- in6_dev->tstamp

But I've looked through ndisc.c and icmp.c, and I can't find anything
that would protect this data from concurrent access.  Is there
something I'm missing?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html