netdev - Re: [PATCH net-next] bridge: implement multicast fast leave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 04 Dec 2012 15:04:52 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Herbert Xu <herbert@...dor.hengli.com.au>
Cc:	Stephen Hemminger <shemminger@...tta.com>, netdev@...r.kernel.org,
	bridge@...ts.linux-foundation.org,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next] bridge: implement multicast fast leave

On Tue, 2012-12-04 at 09:38 +0800, Herbert Xu wrote:
> On Mon, Dec 03, 2012 at 07:53:16AM -0800, Stephen Hemminger wrote:
> > On Mon,  3 Dec 2012 22:36:03 +0800
> > Cong Wang <amwang@...hat.com> wrote:
> > 
> > > Fast leave allows bridge to immediately stops the multicast
> > > traffic on the port receives IGMP Leave when IGMP snooping is enabled,
> > > no timeouts are observed.
> > > 
> > > Cc: Herbert Xu <herbert@...dor.apana.org.au>
> > > Cc: Stephen Hemminger <shemminger@...tta.com>
> > > Cc: "David S. Miller" <davem@...emloft.net>
> > > Signed-off-by: Cong Wang <amwang@...hat.com>
> > 
> > I like the feature, and it looks like an oversight in the initial design.
> > Why is this not the default, adding more options obscures it.
> 
> If the port has a bridge on it then you're toast.  I think this
> should be a per-port option.

Per-port sounds better than per-bridge. And I will make it enabled by
default.

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html